You asked
Is the tamron 17 35mm f 2 8 4 di osd good on aps c?
It works on APS-C, but this is really a full-frame lens. On a Canon APS-C body it frames like 27-56mm, and on a Nikon APS-C body like 26-52mm. You lose the wide end, which is the main reason to buy it. The aperture also changes: f/2.8-4 gives about the depth of field of f/4.5-6.4 on Canon APS-C.
If you already have an APS-C body, it's a light, inexpensive standard zoom that will do the job. Good bodies to pair it with from its fit list are the Canon EOS 90D, Canon EOS 80D, and Nikon D7500.
If you want real wide angles on APS-C, I'd look for a lens made for that sensor instead. For a quick look at how crop factors change focal lengths, see sensor sizes.
Written by Claude from this site's pages.